fix(helm): allow duplicate keys in template #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
approved these changes
Feb 22, 2019
Prevents "duplicated mapping key" errors when loading remote charts with duplicate keys (e.g. official ambassador chart).
eysi09
force-pushed
the
helm-handle-dupe-keys
branch
from
545f26d to
5153857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents "duplicated mapping key" errors when loading remote charts with duplicate keys (e.g. official ambassador chart).
When loading the template with
{ json: true }, duplicate keys in a mapping will override values rather than throwing an error.However, this behavior is broken for the
safeLoadAllfunction, see: nodeca/js-yaml#456. We therefore need to use theloadAllfunction. See the following link for a conversation on usingloadAllin this context: vmware-tanzu/kubeapps#636.